View Change

8 comments:

• Commit Message:

  • Patch Set #1, Line 9: Add the configuration in device tree:

    I would recommend splitting each device configuration into a CL of their own.

  • Patch Set #1, Line 14: 5. Add WiFi configuration

    Is metaknight using Discrete WiFi or CNVi?

  • Patch Set #1, Line 15: 6. Add DPTF setting

    Is the DPTF value tuned already. If not, I would recommend you to drop it and use the baseboard DPTF configuration for now. Once you have the tuned value, it can be added.

• File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:

  • Patch Set #1, Line 35:

    		.i2c[3] = {
    			.speed = I2C_SPEED_FAST,
    		},
    

    Can be removed.

  • Patch Set #1, Line 41: }"

    Disable I2C3

    	register "SerialIoI2cMode" = "{
    		[PchSerialIoIndexI2C0]  = PchSerialIoPci,
    		[PchSerialIoIndexI2C1]  = PchSerialIoPci,
    		[PchSerialIoIndexI2C2]  = PchSerialIoPci,
    		[PchSerialIoIndexI2C3]  = PchSerialIoDisabled,
    		[PchSerialIoIndexI2C4]  = PchSerialIoPci,
    		[PchSerialIoIndexI2C5]  = PchSerialIoPci,
    	}"

  • Patch Set #1, Line 90: Camera

    User Facing Camera

  • Patch Set #1, Line 95: Camera

    World Facing Camera

  • Patch Set #1, Line 106: "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)"

    We recently learnt that HID over I2C uses Level triggered IRQs. So needs to be fixed. Same for all the I2C Human Interface Devices.

To view, visit change 47013. To unsubscribe, or for help writing mail filters, visit settings.