View Change

1 comment:

• File src/soc/intel/apollolake/mmap_boot.c:

  • Patch Set #12, Line 85:

    map = rdev_mmap(&real_dev.rdev, region_offset(&cbfs_region), region_sz(&cbfs_region));
    	if (map)
    		rdev_munmap(&real_dev.rdev, map);
    

    if I understand this part right, wouldn't […]

    region_overlap() would be true if only part of it were overlapping so maybe not enough? whereas mmap would end up calling region_is_subregion() for checking.

To view, visit change 47658. To unsubscribe, or for help writing mail filters, visit settings.