[coreboot-gerrit] New patch to review for coreboot: ac11f4f AGESA fam16kb: Move NB config fam16kb out of get_bus_conf()

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6357

-gerrit

commit ac11f4f96201c91418fe216f02a7ee30a941175d
Author: Kyösti Mälkki 
Date:   Tue Jul 22 19:27:52 2014 +0300

AGESA fam16kb: Move NB config fam16kb out of get_bus_conf()

Change-Id: Iedb5e1c72afe70f63f39c2dbce4896863d1d275f
    Signed-off-by: Kyösti Mälkki 
---
 src/cpu/amd/agesa/amd_late_init.c            | 14 ++++++++++++++
 src/mainboard/amd/olivehill/get_bus_conf.c   | 14 --------------
 src/mainboard/asrock/imb-a180/get_bus_conf.c | 10 ----------
 3 files changed, 14 insertions(+), 24 deletions(-)

diff --git a/src/cpu/amd/agesa/amd_late_init.c b/src/cpu/amd/agesa/amd_late_init.c
index f893741..c8b941d 100644
--- a/src/cpu/amd/agesa/amd_late_init.c
+++ b/src/cpu/amd/agesa/amd_late_init.c
@@ -43,6 +43,20 @@ static void agesawrapper_post_device(void *unused)
    /* Preparation for write_tables(). */
    get_bus_conf();

+#if IS_ENABLED(CONFIG_NORTHBRIDGE_AMD_AGESA_FAMILY_16KB)
+	device_t dev;
+	u32 value;
+	dev = dev_find_slot(0, PCI_DEVFN(0, 0)); /* clear IoapicSbFeatureEn */
+	pci_write_config32(dev, 0xF8, 0);
+	pci_write_config32(dev, 0xFC, 5); /* TODO: move it to dsdt.asl */
+
+	/* disable No Snoop */
+	dev = dev_find_slot(0, PCI_DEVFN(1, 1));
+	value = pci_read_config32(dev, 0x60);
+	value &= ~(1 << 11);
+	pci_write_config32(dev, 0x60, value);
+#endif
+
 #if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
    /* AMD AGESA does not enable thermal zone, so we enable it here. */
    enable_imc_thermal_zone();
diff --git a/src/mainboard/amd/olivehill/get_bus_conf.c b/src/mainboard/amd/olivehill/get_bus_conf.c
index a58c61f..2765ed7 100644
--- a/src/mainboard/amd/olivehill/get_bus_conf.c
+++ b/src/mainboard/amd/olivehill/get_bus_conf.c
@@ -39,23 +39,9 @@ u32 apicid_yangtze;
 void get_bus_conf(void)
 {
    u32 apicid_base;
-	u32 value;

device_t dev;
    int i;
-
-
-	dev = dev_find_slot(0, PCI_DEVFN(0, 0)); /* clear IoapicSbFeatureEn */
-	pci_write_config32(dev, 0xF8, 0);
-	pci_write_config32(dev, 0xFC, 5); /* TODO: move it to dsdt.asl */
-
-	/* disable No Snoop */
-	dev = dev_find_slot(0, PCI_DEVFN(1, 1));
-	value = pci_read_config32(dev, 0x60);
-	value &= ~(1 << 11);
-	pci_write_config32(dev, 0x60, value);
-
-
    memset(bus_yangtze, 0, sizeof(bus_yangtze));

diff --git a/src/mainboard/asrock/imb-a180/get_bus_conf.c b/src/mainboard/asrock/imb-a180/get_bus_conf.c
index 17ff8a5..9a20b98 100644
--- a/src/mainboard/asrock/imb-a180/get_bus_conf.c
+++ b/src/mainboard/asrock/imb-a180/get_bus_conf.c
@@ -37,20 +37,10 @@ u32 apicid_yangtze;
 void get_bus_conf(void)
 {
    u32 apicid_base;
-	u32 value;

device_t dev;
    int i;

-	dev = dev_find_slot(0, PCI_DEVFN(0, 0)); /* clear IoapicSbFeatureEn */
-	pci_write_config32(dev, 0xF8, 0);
-	pci_write_config32(dev, 0xFC, 5); /* TODO: move it to dsdt.asl */
-
-	/* disable No Snoop */
-	dev = dev_find_slot(0, PCI_DEVFN(1, 1));
-	value = pci_read_config32(dev, 0x60);
-	value &= ~(1 << 11);
-	pci_write_config32(dev, 0x60, value);

memset(bus_yangtze, 0, sizeof(bus_yangtze));