Attention is currently required from: Nico Huber, Maxim Polyakov.
Patch set 30:Code-Review +1
1 comment:
File src/soc/intel/apollolake/romstage.c:
mupd->FspmConfig.PrimaryVideoAdaptor =
is_devfn_enabled(SA_DEVFN_IGD) && CONFIG(ONBOARD_VGA_IS_PRIMARY) ?
GPU_PRIMARY_IGD : GPU_PRIMARY_PCI;
nit: I'd do the Kconfig check first so that the compiler can optimise things out when it's false. Also, I'd split this into multiple statements for clarity:
if (CONFIG(ONBOARD_VGA_IS_PRIMARY) && is_devfn_enabled(SA_DEVFN_IGD))
mupd->FspmConfig.PrimaryVideoAdaptor = GPU_PRIMARY_IGD;
else
mupd->FspmConfig.PrimaryVideoAdaptor = GPU_PRIMARY_PCI;
To view, visit change 39374. To unsubscribe, or for help writing mail filters, visit settings.