Note that you're not supposed to give yourself Code-Review+2 (and it doesn't work, anyway).
4 comments:
File src/soc/mediatek/mt8183/emi.c:
Patch Set #11, Line 51: enum {
Rather than this and a raw uint array, please define a struct with three members.
Patch Set #11, Line 59: 1125000, 600000
If the latter two values are always constant, do they really need to be in here?
Patch Set #11, Line 400: #if DUAL_FREQ_K
This seems to be like a very complicated way to write
{
if (DUAL_FREQ_K) {
set_dram_voltabe_by_freq(LP4X_LOW);
...
set_dram_voltage_by_freq(LP4X_MIDDLE);
...
}
set_dram_voltage_by_freq(LP4X_HIGH);
...
}
File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
Patch Set #11, Line 41: #define DUAL_FREQ_K 0
What is this? If you want configurable code paths, use Kconfig.
To view, visit change 35017. To unsubscribe, or for help writing mail filters, visit settings.