33 comments:
- Linux
- GRUB, SeaBIOS
Devuan ascii, kernel 4.9.0 […]
Done
File src/mainboard/apple/macbookair5_2/Kconfig:
Done
Done
File src/mainboard/apple/macbookair5_2/Kconfig:
Patch Set #23, Line 31: default "pci8086,0166.rom"
Is the VBIOS tested?
File src/mainboard/apple/macbookair5_2/Makefile.inc:
cbfs-files-y += spd.bin
spd.bin-file := spd.bin
spd.bin-type := spd
I think you can use GENERIC_SPD_BIN. see src/mb/hp/snb_ivb_laptops as an example (the revolve 810 uses that mechanism)
Note that it uses plaintext SPD files, so you may have to xxd your file
File src/mainboard/apple/macbookair5_2/acpi_tables.c:
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
These can be dropped
Patch Set #23, Line 28: // the lid is open by default.
Please use C-style comments for consistency
File src/mainboard/apple/macbookair5_2/devicetree.cb:
Add this line here: […]
Done
Patch Set #1, Line 110: Host bridge
Duplicate comment
Done
device pci 00.0 on # Host bridge Host bridge
subsystemid 0x106b 0x00fe
end
device pci 01.0 off # PCIe Bridge for discrete graphics
end
device pci 02.0 on # Internal graphics VGA controller
subsystemid 0x106b 0x00fe
end
Please move above the "chip southbridge/intel/bd82x6x" line
Done
File src/mainboard/apple/macbookair5_2/devicetree.cb:
Patch Set #23, Line 2: register "gfx.did" = "{ 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }"
This can be dropped
0
0
0
Patch Set #23, Line 44: register "docking_supported" = "0"
is zero, can be dropped
Patch Set #23, Line 50: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
is zero, can be dropped
Patch Set #23, Line 66: High Definition Audio Audio
Stereo audio again :^)
File src/mainboard/apple/macbookair5_2/dsdt.asl:
#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB
#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB
#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Are these used?
Patch Set #23, Line 28: /* Some generic macros */
Please remove this comment. I killed it on a recent change.
#include <southbridge/intel/bd82x6x/acpi/platform.asl>
/* global NVS and variables. */
#include <southbridge/intel/bd82x6x/acpi/globalnvs.asl>
#include <southbridge/intel/bd82x6x/acpi/sleepstates.asl>
Some of these are now under common
File src/mainboard/apple/macbookair5_2/gma-mainboard.ads:
Patch Set #23, Line 30: Analog
This one is likely to be unused
File src/mainboard/apple/macbookair5_2/gnvs.c:
This file is a duplicate of acpi_tables.c […]
See current patchset
File src/mainboard/apple/macbookair5_2/gnvs.c:
This file is a duplicate of acpi_tables.c
It doesn't even get built. Please remove.
File src/mainboard/apple/macbookair5_2/hda_verb.c:
Patch Set #23, Line 21: Cirrus
Cirrus CS4206
Patch Set #23, Line 24: 0x0000000b
Use decimal here
Patch Set #23, Line 25: /* NID 0x01: Subsystem ID. */
All of the "NID" comments are of no use, they can be dropped
Use decimal here as well
Patch Set #23, Line 57: 0x80862806, /* Codec Vendor / Device ID: Intel */
Add a space between the two codecs
Patch Set #23, Line 60: 0x00000004
Also decimal
Also decimal
Patch Set #23, Line 75: 0x00270500, /* Set PS to D0 on DAC1 */
please, no spaces at the start of a line
Please correct this
File src/mainboard/apple/macbookair5_2/mainboard.c:
Patch Set #1, Line 62: GMA_INT15_ACTIVE_LFP_EDP
Confirmed, it's eDP. Please format this line properly, though.
Ack
File src/mainboard/apple/macbookair5_2/mainboard.c:
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP,
GMA_INT15_PANEL_FIT_DEFAULT,
GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
Is the VBIOS tested?
File src/mainboard/apple/macbookair5_2/romstage.c:
Patch Set #23, Line 73: memcpy(&spd[0], spd_file, 128);
Why is only half of the spd file used? Only the 1st and 3rd quarters are used.
To view, visit change 32604. To unsubscribe, or for help writing mail filters, visit settings.