Felix Held has uploaded this change for review.

View Change

lib/smbios: rename segment group parameter of smbios_write_type41

Rename the segment group parameter of smbios_write_type41 from 'segment'
to 'segment_group' to be in line with the PCI specification.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie6ca0ce8b6b3b0357df72bafa2b6069132d0937e
---
M src/include/smbios.h
M src/lib/smbios.c
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/79926/1

diff --git a/src/include/smbios.h b/src/include/smbios.h
index f821980..d4ae662 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -41,7 +41,7 @@
 			const u64 base_addr, const u8 base_modifier,
 			const u8 irq);
 int smbios_write_type41(unsigned long *current, int *handle,
-			const char *name, u8 instance, u16 segment,
+			const char *name, u8 instance, u16 segment_group,
 			u8 bus, u8 device, u8 function, u8 device_type);
 enum smbios_temp_location;
 enum smbios_temp_status;
diff --git a/src/lib/smbios.c b/src/lib/smbios.c
index fb68b4f..12fbdfa 100644
--- a/src/lib/smbios.c
+++ b/src/lib/smbios.c
@@ -971,7 +971,7 @@
 }
 
 int smbios_write_type41(unsigned long *current, int *handle,
-			const char *name, u8 instance, u16 segment,
+			const char *name, u8 instance, u16 segment_group,
 			u8 bus, u8 device, u8 function, u8 device_type)
 {
 	struct smbios_type41 *t = smbios_carve_table(*current,
@@ -982,7 +982,7 @@
 	t->device_type = device_type;
 	t->device_status = 1;
 	t->device_type_instance = instance;
-	t->segment_group_number = segment;
+	t->segment_group_number = segment_group;
 	t->bus_number = bus;
 	t->device_number = device;
 	t->function_number = function;
@@ -1114,7 +1114,7 @@
 	return smbios_write_type41(current, handle,
 					name, // name
 					instance_id, // inst
-					0, // segment
+					0, // segment group
 					dev->bus->secondary, //bus
 					PCI_SLOT(dev->path.pci.devfn), // device
 					PCI_FUNC(dev->path.pci.devfn), // func

To view, visit change 79926. To unsubscribe, or for help writing mail filters, visit settings.