Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: [WIP] intel/skylake: Implement PCIe RP devicetree update based on DID ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35985/5/src/soc/intel/skylake/chip_... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35985/5/src/soc/intel/skylake/chip_... PS5, Line 67: default: : printk(BIOS_WARNING, : "%s: Unexpected DID for PCIe Root Port at PCI %x:%02x.%x: %04x.\n", : __func__, PCI_DEV2SEGBUS(dev), PCI_SLOT(PCI_DEV2DEVFN(dev)), : PCI_FUNC(PCI_DEV2DEVFN(dev)), did); this will warn for disabled ports. I don't think we want that. move down and break in case 0xfff0
https://review.coreboot.org/c/coreboot/+/35985/5/src/soc/intel/skylake/chip_... PS5, Line 73: 0xffff 0xfff0