View Change

24 comments:

• File src/mainboard/kontron/bSC2/Kconfig:

  • Patch Set #2, Line 48:

    trailing whitespace

• File src/mainboard/kontron/bSC2/acpi/superio.asl:

  • Patch Set #2, Line 50: IQ01, 8,

    trailing whitespace

• File src/mainboard/kontron/bSC2/devicetree.cb:

  • Patch Set #2, Line 47: device pci 16.1 off end # Management Engine Interface 2

    trailing whitespace

  • Patch Set #2, Line 88: io 0x62 = 0x64

    trailing whitespace

• File src/mainboard/kontron/bSC2/early_init.c:

  • Patch Set #2, Line 33: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1403); /* COMA, COMB, KBC and LPC 0x2E enabled */

    trailing whitespace

  • Patch Set #2, Line 33: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1403); /* COMA, COMB, KBC and LPC 0x2E enabled */

    line over 96 characters

  • Patch Set #2, Line 34: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); /* LPC decode ranges COMA=3F8, COMB=2F8 */

    line over 96 characters

• File src/mainboard/kontron/bSC2/mainboard.c:

  • Patch Set #2, Line 41: #define adt7490_write_byte(reg, val) do_smbus_write_byte(smbus_io_base, adt7490_address, reg, val)

    line over 96 characters

  • Patch Set #2, Line 101: if ((vendid = 0x41) && // Analog Devices

    code indent should use tabs where possible

  • Patch Set #2, Line 101: if ((vendid = 0x41) && // Analog Devices

    please, no spaces at the start of a line

  • Patch Set #2, Line 101: if ((vendid = 0x41) && // Analog Devices

    do not use assignment in if condition

  • Patch Set #2, Line 102: (devid2 & 0xfc) == 0x6c) { // Device ID

    code indent should use tabs where possible

  • Patch Set #2, Line 102: (devid2 & 0xfc) == 0x6c) { // Device ID

    please, no spaces at the start of a line

  • Patch Set #2, Line 108: adt7490_write_byte(CONF_REG_1, 0x15); // Monitoring and PWM control outputs enabled

    line over 96 characters

  • Patch Set #2, Line 109: adt7490_write_byte(PWM1_CONF_REG, 0x42); // 250ms spin time, Remote 2 temp. controls PWM1

    line over 96 characters

  • Patch Set #2, Line 110: adt7490_write_byte(R2_TRAN_PWM3_FREQ, 0xB4); // Frequency = 35.3 Hz, low frequency PWM mode,

    trailing whitespace

  • Patch Set #2, Line 110: adt7490_write_byte(R2_TRAN_PWM3_FREQ, 0xB4); // Frequency = 35.3 Hz, low frequency PWM mode,

    line over 96 characters

  • Patch Set #2, Line 112: adt7490_write_byte(PWM1_MIN_DUTY_CYCLE, 0x54);

    trailing whitespace

  • Patch Set #2, Line 114: adt7490_write_byte(R2_TEMP_TMIN, 0x37); // When the temperature measured exceeds T MIN , the

    trailing whitespace

  • Patch Set #2, Line 114: adt7490_write_byte(R2_TEMP_TMIN, 0x37); // When the temperature measured exceeds T MIN , the

    line over 96 characters

  • Patch Set #2, Line 115: // appropriate fan runs at minimum speed and

    trailing whitespace

  • Patch Set #2, Line 115: // appropriate fan runs at minimum speed and

    line over 96 characters

  • Patch Set #2, Line 116: // increases with temperature according to T RANGE.

    line over 96 characters

  • Patch Set #2, Line 119: adt7490_write_byte(THERM_TIMER_LIMIT, 0xFF); // Avoid unwanted alerts from being generated.

    line over 96 characters

To view, visit change 45658. To unsubscribe, or for help writing mail filters, visit settings.