Attention is currently required from: Noga Smith, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.

Patch set 15:Verified +1

View Change

4 comments:

• File src/soc/intel/meteorlake/gpio.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496):

    Patch Set #15, Line 79: INTEL_GPP_BASE(GPP_B0, GPP_D0, GPP_BOOTHALT_B, 256, "D"), /* GPP_D */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496):

    Patch Set #15, Line 79: INTEL_GPP_BASE(GPP_B0, GPP_D0, GPP_BOOTHALT_B, 256, "D"), /* GPP_D */

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496):

    Patch Set #15, Line 80: INTEL_GPP(GPP_B0, GPP_VGPIO0, GPP_VGPIO47, "VGPIO0"), /* GPP_VGPIO0 */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150496):

    Patch Set #15, Line 80: INTEL_GPP(GPP_B0, GPP_VGPIO0, GPP_VGPIO47, "VGPIO0"), /* GPP_VGPIO0 */

    please, no spaces at the start of a line

To view, visit change 64169. To unsubscribe, or for help writing mail filters, visit settings.