Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: intel/skylake: Implement PCIe RP devicetree update based on LCAP
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35985/18/src/soc/intel/common/block...
File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/35985/18/src/soc/intel/common/block...
PS18, Line 141: for (dev = *ptr; dev; dev = *ptr) {
: if (dev->path.type != DEVICE_PATH_PCI) {
: ptr = &dev->sibling;
: continue;
: }
:
: offset = 0;
: for (group = groups; group->count; ++group) {
: if (group->slot == PCI_SLOT(dev->path.pci.devfn))
: break;
: offset += group->count;
: }
: if (!group->count) {
: ptr = &dev->sibling;
: continue;
: }
:
: if (pcie_rp_update_dev(dev, offset, mapping) < 0) {
: /* Unlink disabled device. */
: *ptr = dev->sibling;
: dev->sibling = NULL;
: }
: }
That reflects the idea but is flawed: […]
Would renaming `ptr` to `link` help?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib17d2b6fd34608603db3936d638bdf5acb46d717
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 18
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 09 Nov 2019 14:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment