Attention is currently required from: Felix Singer, Marvin Drees.
View Change
1 comment:
Commit Message:
Patch Set #16, Line 24:
- Figure out why system_reset() gets called during
FSP MemoryInit on cold boot once
If by "cold boot" you mean after the power supply was unplugged, it's completely normal.
I'm pretty sure it's the same as on Haswell, where the ME needs a `system_reset()` to perform "dynamic fusing". I don't know what exactly this "dynamic fusing" does, but it updates the CAPID0 register in the host bridge's PCI config space, most likely according to the capabilities of the processor and PCH. I think this is how Intel restricts memory overclocking to mainboards with a Z-series PCH, among other things.
To view, visit change 48648. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab30596f2a12931679687c9f56427712b65f9363
Gerrit-Change-Number: 48648
Gerrit-PatchSet: 16
Gerrit-Owner: Marvin Drees <marvin.drees@9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Marvin Drees <marvin.drees@9elements.com>
Gerrit-Comment-Date: Tue, 17 Aug 2021 15:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment