Patrick Rudolph has uploaded this change for review.

View Change

superio/common/ssdt: Make disabled PNP devices ACPI compliant

Always write a _HID, even for disabled PNP devices.

Fixes a BSOD on Windows 10.

Change-Id: I419a08bd6a3570fb4e1ae31bef4f9ccd6836fe1b
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
M src/superio/common/ssdt.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/37692/1
diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c
index a919aa5..563178c 100644
--- a/src/superio/common/ssdt.c
+++ b/src/superio/common/ssdt.c
@@ -203,6 +203,9 @@
acpigen_write_STA(dev->enabled ? 0xf : 0);

if (!dev->enabled) {
+ /* To be ACPI compliant, always write a _HID */
+ acpigen_write_name_string("_HID", ACPI_HID_PNP);
+
acpigen_pop_len(); /* Device */
acpigen_pop_len(); /* Scope */
return;

To view, visit change 37692. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419a08bd6a3570fb4e1ae31bef4f9ccd6836fe1b
Gerrit-Change-Number: 37692
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-MessageType: newchange