Attention is currently required from: Hung-Te Lin, Wenbin Mei.
38 comments:
File src/commonlib/include/commonlib/sd_mmc_ctrlr.h:
Patch Set #2, Line 15: MMC_CMD1_READY
I think you tried to use -1 as well, so let's add […]
Done
File src/mainboard/google/asurada/Kconfig:
Patch Set #3, Line 33: select COMMONLIB_STORAGE_MMC
Please do the board changes in a separate commit.
Done
File src/mainboard/google/asurada/mainboard.c:
#include <commonlib/storage/sd_mmc.h>
#include <commonlib/sd_mmc_ctrlr.h>
#include <commonlib/storage.h>
#include <cbmem.h>
#include <soc/msdc.h>
Sort
Ack
Align using tabs
Ack
I
Done
Patch Set #2, Line 247: 400*1000
400 * 1000
Done
File src/soc/mediatek/common/include/soc/msdc.h:
Patch Set #3, Line 2: #ifndef __MSDC_H_
Please add a blank line above.
Done
File src/soc/mediatek/common/include/soc/msdc.h:
MIN() is already defined in commonlib/bsd/include/commonlib/bsd/helpers. […]
Done
File src/soc/mediatek/common/msdc.c:
Remove this
Done
Patch Set #2, Line 25: msdc_poll_timeout -
No need for this
Done
Extra blank line
Done
Patch Set #2, Line 35: status
This is always NULL in all calls.
Done
Patch Set #2, Line 42: timeout == 0
Use "!--timeout" as in msdc_wait_done().
Done
%#x
Ack
%#x
Ack
/* This is a private function to wait for a bit mask in a given register */
/* To avoid endless loops, a time-out is implemented here. */
Format: […]
Done
if (reg & mask)
goto end;
This can be removed if we replace the do-while loop with while-do loop.
Done
space
Done
Patch Set #2, Line 120: MSDC_PATCH_BIT1_STOP_DLY
Align with "host->base". Same below.
Done
Patch Set #2, Line 129: MSDC_PB2_RESPWAIT, 3);
Fit in one line
Done
U
Done
need to
Done
Patch Set #2, Line 138: MSDC_PATCH_BIT2_CFGRESP);
Fit in one line
Done
Wrong format
Done
Patch Set #2, Line 156: it's must otherwise sdio cmd5 failed
Otherwise, sdio cmd5 will fail.
Done
Indent
Ack
%#x
Done
%#x
Done
Patch Set #2, Line 234: unsigned int
uint32_t
Done
(read32(host->base + MSDC_FIFOCS) & MSDC_FIFOCS_TXCNT) >> 16 ||
read32(host->base + MSDC_FIFOCS) & MSDC_FIFOCS_RXCNT
Just […]
Done
Patch Set #2, Line 359: div_width
Add 'const', and no need to assert(div_width > 0)
Done
Patch Set #2, Line 454: 0x%08x
%#010x
Done
Patch Set #2, Line 461: 0x%08x
%#010x
Done
File src/soc/mediatek/common/msdc.c:
Patch Set #3, Line 465: printk(BIOS_INFO, "status = %d\n", status);
Info level messages should be understandable for users. Please rephrase or make it a debug message.
Done
File src/soc/mediatek/common/msdc.c:
space
Patch Set #4, Line 133: MSDC_PAD_TUNE_CMD_SEL
Move to the previous line
Align with BIOS_ERR
File src/soc/mediatek/mt8192/Makefile.inc:
Patch Set #2, Line 65: ramstage-y += ../common/msdc.c
Sort
Done
To view, visit change 51966. To unsubscribe, or for help writing mail filters, visit settings.