5 comments:
File src/mainboard/google/dedede/romstage.c:
extra tab not required.
same here.
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
Patch Set #18, Line 117: RAM_STRAP_0
These straps should be configured in gpio_table above as well.
File src/mainboard/google/dedede/variants/waddledoo/Makefile.inc:
Patch Set #18, Line 16: empty
So, ID 0 is empty on waddledoo? Why are we leaving empty slots. We should start indexing from 0. This comment is more from our board hardware design standpoint.
File src/mainboard/google/dedede/variants/waddledoo/memory.c:
Patch Set #18, Line 23: /* Access memory info through CBFS */
Comment seems misplaced.
To view, visit change 39136. To unsubscribe, or for help writing mail filters, visit settings.