>> I'm rather sure that SET_VESA_MODE alone doesn't make a difference.
>>
>
> Indeed, you are right! I just tested a BMP splashscreen (and also found out how to get it working after so many attempts - more information at https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/4L3CWZV4NW3QXXFNK6AZCFOCWLXH3Q5J/ ) and it worked for both builds, the only difference between which - was a FRAMEBUFFER_SET_VESA_MODE config enabled/disabled.
That's about SeaBIOS' bootsplash feature not coreboot's ;)
coreboot has it's own (probably not used in 10 years)
version that works only with VBIOS and a VBE mode. So by
default the VBE mode is only set for that and coreboot
would return to text mode before booting the payload
(unless configured otherwise, VBE_LINEAR_FRAMEBUFFER,
IIRC).
If you ask me, we could just remove that feature from
coreboot.
>> You cannot sign off for other people.
>
> He entrusted me to work on his patches to get them merged (he already worked a lot to develop them, now it's my turn to do a fair share), and I promised to mention him at my submissions. I think I've seen it at some Linux kernel patches where a team of developers have been working on some patches, and all these developers have been mentioned this way to give them credit - while just one person has been sending them; so I thought it's a correct way to do it.
It's not about crediting, it's about legality issues:
https://coreboot.org/Development_Guidelines#Sign-off_Procedure
You can add a signed-off-by for other people only if they
explicitly agreed to that.
To view, visit change 31325. To unsubscribe, or for help writing mail filters, visit settings.