Felix Held submitted this change.
drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected
Platforms that rely on the FSP for parts of the hardware initialization
likely won't boot successfully when no FSP binaries are added during the
build, so print a warning at the end of the build in this case.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Nico Huber <nico.h@gmx.de>
Suggested-by: Martin Roth <martinroth@google.com>
Change-Id: I6efc184ecc4059818474937fd31574f703c9bdc6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57368
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M src/drivers/intel/fsp2_0/Makefile.inc
1 file changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc
index 80dc93b..01b4c9e 100644
--- a/src/drivers/intel/fsp2_0/Makefile.inc
+++ b/src/drivers/intel/fsp2_0/Makefile.inc
@@ -110,8 +110,17 @@
ifeq ($(call strip_quotes,$(CONFIG_FSP_S_FILE)),)
$(error No FSP-S binary file specified.)
endif # CONFIG_FSP_S_FILE
+else # CONFIG_ADD_FSP_BINARIES
+build_complete:: warn_no_fsp_binaries
endif # CONFIG_ADD_FSP_BINARIES
+PHONY+=warn_no_fsp_binaries
+warn_no_fsp_binaries:
+ printf "\n\t** WARNING **\n"
+ printf "ADD_FSP_BINARIES isn't selected even though this SoC relies on the FSP.\n"
+ printf "The resulting image won't contain the FSP binaries and will not boot unless\n"
+ printf "they are added later.\n"
+
subdirs-y += ppi
endif
To view, visit change 57368. To unsubscribe, or for help writing mail filters, visit settings.