Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38741/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38741/9//COMMIT_MSG@9 PS9, Line 9: Current(TDC) Please add a space before (.
https://review.coreboot.org/c/coreboot/+/38741/9//COMMIT_MSG@11 PS9, Line 11: 2.TdcPowerLimit Please add a space after the enumerator(?).
- TdcEnable
- TdcPowerLimit
https://review.coreboot.org/c/coreboot/+/38741/9//COMMIT_MSG@15 PS9, Line 15: check FSP log Check for what?
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/in... PS9, Line 58: * Please remove.
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/in... PS9, Line 61: /* Thermal Design Current(TDC) Power Limit in 1/8 A units */ Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/vr... PS9, Line 506: 0x%x %#x
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/vr... PS9, Line 507: "Auto/default settings\n", mch_id); 1. Strings should be on one line. 2. Maybe: Unknown MCH (%#x) in VR-config, so apply defaults