View Change
1 comment:
File src/lib/spd_bin.c:
Patch Set #58, Line 147: size_t *len)
nit: This will fit on the previous line within the 96-column limit.
Then we need to fix checkpatch :
Running checkpatch
WARNING: line over 80 characters
#11: FILE: src/lib/spd_bin.c:146:
+static void spd_get_name(const uint8_t spd[], int type, const char **spd_name, size_t *len)
Should I bypass checkpatch with --no-verify? I don't generally like to do that.
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 59
Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Fri, 02 Oct 2020 21:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment