View Change
1 comment:
Commit Message:
Patch Set #1, Line 11: Now
Why are we hit now by this?
This happened because of the SPDX-replacing changes. After splitting the big CB:40045 change into smaller parts, one of the changes happened to move only part of the code using the macros, which resulted in two instances of `dead_code` in two different files to end up on the same line. And well, this broke master in a spectacular way...
I'm marking this as resolved so that ACR does not block submit. Since master is currently broken, this should get merged ASAP.
To view, visit change 40140. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c548ce998cf8e28ae9f76b5c0ea5630b4e91ae2
Gerrit-Change-Number: 40140
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 04 Apr 2020 21:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment