View Change

4 comments:

• File src/mainboard/google/kahlee/variants/treeya/mainboard.c:

  • Patch Set #5, Line 28:

    uint32_t sku_id(void)
    {
    	static int sku = -1;
    
    	if (sku == -1)
    		sku = google_chromeec_get_sku_id();
    
    	return sku;
    }
    
    uint8_t variant_board_sku(void)
    {
    	return sku_id();
    }
    
    void variant_mainboard_suspend_resume(void)
    {
    	/* Enable backlight - GPIO 133 active low */
    	gpio_set(GPIO_133, 0);
    }
    

    Do you need to copy this as well?

  • Patch Set #5, Line 97: 0x304

    Can you #define this constant

  • Patch Set #5, Line 100: 0x30

    #define as well.

  • Patch Set #5, Line 107:

    const char *smbios_mainboard_manufacturer(void)
    {
    	static char oem_bin_data[11];
    	static const char *manuf;
    
    	if (!CONFIG(USE_OEM_BIN))
    		return CONFIG_MAINBOARD_SMBIOS_MANUFACTURER;
    
    	if (manuf)
    		return manuf;
    
    	if (cbfs_boot_load_file("oem.bin", oem_bin_data,
    					    sizeof(oem_bin_data) - 1,
    					    CBFS_TYPE_RAW))
    		manuf = &oem_bin_data[0];
    	else
    		manuf = CONFIG_MAINBOARD_SMBIOS_MANUFACTURER;
    
    	return manuf;
    }
    

    Do you also need this?

To view, visit change 37458. To unsubscribe, or for help writing mail filters, visit settings.