Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76137?usp=email )
Change subject: mb/google/rex: Set AUX orientation at SoC to follow cable for kb8010 ......................................................................
mb/google/rex: Set AUX orientation at SoC to follow cable for kb8010
This configures the SoC to flip the orientation of the AUX pins to follow the orientation of the cable when using the kb8010 retimer. This is necessary when there is no external retimer/mux or the retimer/mux does not implement the flip. The kb8010 retimer does not support this feature, so let the SoC do the flip.
BUG=b:267589112 TEST=verified DP-ALT mode works in both cable orientations on rex with reworked kb8010 DB by flykt@
Change-Id: Iad093e27617b80f8301008deb00b57fb9b3a48ba Signed-off-by: Caveh Jalali caveh@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/76137 Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/mainboard/google/rex/variants/rex0/variant.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/rex0/variant.c b/src/mainboard/google/rex/variants/rex0/variant.c index 032eef9..8cf8ce2 100644 --- a/src/mainboard/google/rex/variants/rex0/variant.c +++ b/src/mainboard/google/rex/variants/rex0/variant.c @@ -31,7 +31,8 @@ config->cnvi_bt_audio_offload = fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S));
- if (fw_config_probe(FW_CONFIG(DB_USB, USB4_ANX7452)) || + if (fw_config_probe(FW_CONFIG(DB_USB, USB4_KB8010)) || + fw_config_probe(FW_CONFIG(DB_USB, USB4_ANX7452)) || fw_config_probe(FW_CONFIG(DB_USB, USB4_ANX7452_V2))) { /* * Configure TCP2 for