View Change
1 comment:
File src/Kconfig:
Patch Set #1, Line 1220: depends on NO_XIP_EARLY_STAGES
Sizewise it indeed seem like a big win. Any idea how compute intensive decompressing is?
It should be barely measurable (e.g. a millisecond or less), LZ4 is super fast. It should always be a win compared to loading more bytes over SPI. The only exceptions would be really pathological cases like running on uncached memory or with a super low CPU clock or something like that.
To view, visit change 36613. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac24d243c4bd4cb8c1db14a8e9fc43f508c2cd5d
Gerrit-Change-Number: 36613
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Mon, 04 Nov 2019 23:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment