Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes.
View Change
1 comment:
Patchset:
Patch Set #1:
soc/amd/picasso and mb/google/zork use hard-coded offsets for this that are non-zero and have an offset of 0x40 bytes into the a/b rw sections cbfs region to take the cbfs header into account. not sure which is correct, but it's different on those two platforms that should be relatively similar. not having some hard-coed values that need to match up with the fmap layout is definitely an advantage though
To view, visit change 61349. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1c2b61c5be0bcab52e19349dacbcc391e8aa909
Gerrit-Change-Number: 61349
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Zieba <robertzieba@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Eric Peers <epeers@google.com>
Gerrit-Attention: Robert Zieba <robertzieba@google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Rob Barnes <robbarnes@google.com>
Gerrit-Comment-Date: Tue, 25 Jan 2022 02:10:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment