>> I don't see a way IGD could be disabled at this stage. But what about
>> SKUs that don't have it at all? are there any (on supported boards)?
>
> 1 - In case we use an external GPU, the IGD is disabled at
> arly_init.c (line #686).

Which is run after raminit.

(BTW: line +949 should be commented)

It doesn't work without that line. You probably mean 950 should
be implemented for the desktop version. Please, go ahead.

2 - there some desktop's version that do not have IGD at all.

That's why I was asking. Are the DEVEN bits hard-wired to 0 for them?

3 - at function "sdram_power_management", we set integrated_graphics
= 1 and use it for test in raminit.c line #2305 .... this do not
make sense.

It documents for the human reader that it should only be executed
when integrated graphics are present (or maybe only when enabled;
that's not clear). This can be useful, for instance, when somebody
wants to implement it for system without IGD.

View Change

To view, visit change 28935. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf
Gerrit-Change-Number: 28935
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas@noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 16:22:40 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No