Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86014?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in romstage
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86014/comment/f0b9976e_2260b87b?usp... :
PS1, Line 8:
Reserve 64KB memory at 0x02140000 for mtk_fsp_romstage.elf.
Done
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86014/comment/4e1205ec_9cbd68a7?usp... :
PS1, Line 102: CBFS_COMPRESS_FLAG
CBFS_PRERAM_COMPRESS_FLAG
Done
https://review.coreboot.org/c/coreboot/+/86014/comment/b66480bd_608448b3?usp... :
PS1, Line 104:
No indentation.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86014?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I73710227e6d9e3f0c717e17db0cc798265eb1f72
Gerrit-Change-Number: 86014
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 03:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com