View Change

2 comments:

• File src/include/device/device.h:

  • Patch Set #1, Line 330: * @return Rounded up number.

    Isn't this just the same as ALIGN_UP(val, 1 << pow)? Why not just get rid of the custom function and use that?

  • Patch Set #1, Line 332: resource_t round(resource_t val, unsigned long pow);

    This needs to be way better namespaced if you want it globally visible (e.g. resource_round_up() or something).

To view, visit change 38727. To unsubscribe, or for help writing mail filters, visit settings.