Attention is currently required from: Dolan Liu, Elyes Haouas, Eric Lai, Jianeng Ceng.
View Change
1 comment:
Commit Message:
Patch Set #9, Line 9: Add RT5645 AMP support.
Pual, […]
Thank you for giving some background. I think, upstream has the policy of reducing duplicate code.
In any case, this decision should be reflected in the commit message. (All questions asked during review should be somehow summarized in the commit message by default.)
To view, visit change 81773. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 23
Gerrit-Owner: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas@noos.fr>
Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Eric Lai <ericllai@google.com>
Gerrit-Attention: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Sat, 20 Apr 2024 05:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai@google.com>
Comment-In-Reply-To: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Comment-In-Reply-To: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-MessageType: comment