Patch Set 4:

I cherry-picked the 3 MTRR changes and the Mandolin support on top of current coreboot master and rebuilt FSP, but first ramstage seems to crash (just stops and bootblock is rung again) and the second time it failed with "FspMemoryInit returned 0x80000003".
Without the 3 patches, but with the freshly built FSP coreboot hangs when running the VBIOS, so I'm reasonably sure that I'm running with the MTRR changes on the FSP side

It sounded like there was something goofed with yesterday's CQ ordering and many people were seeing problems. So hopefully if you give it another try it'll be OK. I did a repo sync Saturday morning and checked it on Mandolin. I rebased these 3 changes on top of 524962 and cherry-picked CB:33772. I'm not seeing the problems you're reporting. Also FWIW I verified the MTRRs are unmodified during the two FSP calls.

Patch set 4:Code-Review +1

View Change

To view, visit change 41898. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8358b614682f6a97278f3a60b5ada5e607965af
Gerrit-Change-Number: 41898
Gerrit-PatchSet: 4
Gerrit-Owner: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 06 Jun 2020 16:35:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment