View Change
1 comment:
Commit Message:
Patch Set #5, Line 7: soc/intel/common/block
(although reset is not any IP block but still a common place where we can refer both core and atom family code like power_limit, acpi etc)
In my opinion, that is not correct. Even power_limit and ACPI should really not be part of common/block. Instead, `basecode` might be a better location? There is nothing under `basecode` right now, so I am unsure what that is supposed to contain. I think we need to keep the separation clean w.r.t. IP blocks and rest of the common code.
we can use basecode, let me try moving this code into basecode and later power_limit and acpi later.
> Unresolved common code macros and function from
Wouldn't those be optimized out by the linker since the older SoCs won't use the cse/pmc related functions?
without any guard, its giving compilation error saying cse_request_global_reset unknown function reference. We could use guard (#if) for sure but i really don't know if that is right way
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 07:49:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subi.banik@gmail.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Gerrit-MessageType: comment