View Change
1 comment:
Commit Message:
Patch Set #5, Line 7: soc/intel/common/block
without any guard, its giving compilation error saying cse_request_global_reset unknown function reference.
I think we can add a check for CONFIG(SOC_INTEL_COMMON_BLOCK_CSE). In general, I think it is confusing that there are two different reset files under common and with very similar functionality.
Can we please make an attempt to consolidate this into a single place? I don't think the cse function call requires #if. You can have a C check:
if (CONFIG(SOC_INTEL_COMMON_BLOCK_CSE))
cse_request_global_reset();
One thing that I think we would need to keep separate is the chipset_handle_reset which is used only by FSP2.0+. Considering that, I think we can have two files under soc/intel/common/basecode/reset:
reset.c - Provides implementation of global_reset, do_global_reset, do_board_reset.
fsp_reset.c - Provides implementation of chipset_handle_reset. This file will get included only if PLATFORM_USES_FSP2_0.
Thoughts?
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subi.banik@gmail.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Gerrit-MessageType: comment