6 comments:
Is this really 3.3V? Its pulled up to 1.8V in schematics.
will confirm. thanks for bringing this up
File src/mainboard/google/hatch/Kconfig:
Patch Set #5, Line 6: DRIVERS_GENERIC_MAX98357A
Can you please place this alphabetically before DRIVERS_I2C_GENERIC?
Sure.
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
Patch Set #5, Line 247: register "probed" = "1"
Probed is not required here.
Yes. i've confirmed that. will update this along with other comments
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
/* PCH_I2C_AUDIO_SDA */
PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1),
/* PCH_I2C_AUDIO_SCL */
PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1),
Can you please order these and the pins below as per GPP_* groups?
Yes. its pending from previous patch set too. Will fix with other comments.
Patch Set #5, Line 163: * AUDIO IRQ
(HP_INT#)
Sure. will correct.
Patch Set #5, Line 168: SPEAKER SD MODE ENABLE
Please use net name as comment so that its easier to compare with schematics.
Will correct it as suggested.
To view, visit change 31280. To unsubscribe, or for help writing mail filters, visit settings.