Patch Set 1:

(1 comment)

Patch Set 1:

Patch Set 1:

Does it make sense to have support for different versions of a binaryPI in coreboot for the same hardware? Why not upgrade to a newer binaryPI?

apu2 platforms have issues with newer binaryPI versions. That's why we stayed with 1.0.0.4

I don't think having binaries + headers depend on a board is a good solution for upstream coreboot, as it creates maintainability issues. Not my call to make though.

Resolving issues with closed source binaries isn't trivial. If we had a solution for the default AGESA 1.0.0.A we would have definitely fix it in mainboard code. I understand your concerns, but what options do we have at this moment? We may only drop this change and hope nothing blows up (fortunately nothing bad happened because of those headers - yet).

View Change

1 comment:

To view, visit change 35906. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d85ee14e35dae8079e8d552b6530a3867f65876
Gerrit-Change-Number: 35906
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Kleinschmidt <piotr.kleinschmidt@3mdeb.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Piotr Kleinschmidt <piotr.kleinschmidt@3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 09 Oct 2019 14:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: comment