Patch Set #1, Line 17:
these days, so nobody noticed.
> It could be that even when implemented for PCIe root ports, CTL_VGA bits for those bridges have no […]
The legacy PCI decodes
* only 10 bits, uses 0x100 - 0x3ff.
I wonder if the comment was supposed to say 'legacy ISA' decodes only 10 bits? […]
Well.. it only took 16 years to notice? […]
Patch Set #1, Line 794:
/* VGA is first add-on card or the only onboard VGA. */
The code here is full of weird assumptions, the comment only adds to it... […]
Um, I guess it's best if you add it with your patch (wasn't sure if you want it […]
Patch Set #1, Line 807:
bridge_ctrl = pci_read_config16(bus->dev, PCI_BRIDGE_CONTROL);
> If upstream bridge supports CTL_VGA16, it does not matter when downstream (including cardbus) brid […]
Patch Set #1, Line 174:
#define PCI_CB_BRIDGE_CTL_VGA 0x08
well, "matches" means we can assume the bit to be reserved for now... […]
To view, visit change 35516. To unsubscribe, or for help writing mail filters, visit settings.