Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60737 )
Change subject: util/ifdtool: Add support for Denverton platforms
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60737/comment/4ed6f972_5d6290a9
PS3, Line 9: pre
why not `coreboot.rom`?
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60737/comment/6839ba36_422c9f9f
PS3, Line 717: has_10gbe_A = (platform == PLATFORM_DNV);
: has_10gbe_B = (platform == PLATFORM_DNV);
Is it necessary to use two equivalent variables?
https://review.coreboot.org/c/coreboot/+/60737/comment/e58e4029_72e1fd84
PS3, Line 1188: switch (platform) {
Shouldn't `PLATFORM_DNV` be handled here too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced
Gerrit-Change-Number: 60737
Gerrit-PatchSet: 3
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 13:39:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment