10 comments:
Patch Set #1, Line 11: maiboard
mainboard
Done
Patch Set #1, Line 12: * PchPmSlpS3MinAssert: SLP_S3 Minimum Assertion Width Policy.
Please add a blank line above.
Done
* PchPmSlpS4MinAssert: SLP_S4 Minimum Assertion Width Policy.
* PchPmSlpSusMinAssert: SLP_SUS Minimum Assertion Width Policy.
* PchPmSlpAMinAssert: SLP_A Minimum Assertion Width Policy.
* PchPmPwrCycDur: PCH PM Reset Power Cycle Duration.
Please remove the dot/period at the end.
Done
File src/soc/intel/jasperlake/chip.h:
Remove or use a colon: […]
Done
Patch Set #1, Line 344: * - PM_CFG.SLP_LAN_MIN_ASST_WDTH
Can you check this with asserts?
Could you elaborate on this question?
File src/soc/intel/jasperlake/fsp_params.c:
MinAssrtDur0s = 0,
MinAssrtDur60us = 60,
MinAssrtDur1ms = 1000,
MinAssrtDur50ms = 50000,
MinAssrtDur98ms = 98000,
MinAssrtDur500ms = 500000,
MinAssrtDur1s = 1000000,
MinAssrtDur2s = 2000000,
MinAssrtDur3s = 3000000,
MinAssrtDur4s = 4000000,
Please use tabs for aligning the =, and please move them closer to the names.
Done
Patch Set #1, Line 74: #define PCH_PM_PWR_CYC_DUR 0
Please use a tab for aligning the 0.
Done
Patch Set #1, Line 170: asserton
assertion
Done
Patch Set #1, Line 190: BIOS_DEBUG
Please make that an error.
Done
Patch Set #1, Line 191: PmPwrCycDur(%d)
Please add a space before the (.
Done
To view, visit change 43791. To unsubscribe, or for help writing mail filters, visit settings.