Patrik Tesarik has uploaded this change for review.

View Change

Documentation/tutorial/part1.md: Apply review comments

Signed-off-by: Patrik Tesarik <mail@patrik-tesarik.de>
Change-Id: I2eb60f507bc67b3bbacaf62f958d069dc7fa0201
---
D 3rdparty/amd_blobs
M Documentation/tutorial/part1.md
2 files changed, 10 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/38302/1
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs
deleted file mode 160000
index cf22731..0000000
--- a/3rdparty/amd_blobs
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit cf227316b0fbd3995854ce21e81a63270b29bfb5
diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md
index 14f7604..cb0640e 100644
--- a/Documentation/tutorial/part1.md
+++ b/Documentation/tutorial/part1.md
@@ -9,9 +9,8 @@

### Step 1 - Install tools and libraries needed for coreboot
$ sudo apt-get install -y bison build-essential curl flex git gnat libncurses5-dev m4 zlib1g-dev
- $ sudo pacman -S base-devel curl git gcc-ada ncurses zlib
- $ sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ ncurses-devel
-wget zlib-devel
+ $ sudo pacman -S base-devel curl git gcc-ada ncurses zlib
+ $ sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ ncurses-devel wget zlib-devel

### Step 2 - Download coreboot source tree
$ git clone https://review.coreboot.org/coreboot
@@ -85,12 +84,12 @@
$ sudo dnf install qemu

### Step 8 - Run QEMU
-Start QEMU and point it to the ROM you just built:
+Start QEMU, and point it to the ROM you just built:

$ qemu-system-x86_64 -bios build/coreboot.rom -serial stdio
$ qemu-system-i386 -bios build/coreboot.rom -serial stdio

-You should see the serial output of coreboot in the original console window and
+You should see the serial output of coreboot in the original console window and,
a new window will appear running the coreinfo payload.

Summary
@@ -99,7 +98,7 @@
### Step 1 summary - Install tools and libraries needed for coreboot
You installed the minimum additional requirements either for Debian, CentOS or
Arch based distributions to download and
-build coreboot. Ubuntu and ArchLinux already has most of the other tools that
+build coreboot. Ubuntu and ArchLinux already has most of the other tools that
would be required installed by default.

* `build-essential` or `base-devel` are the basic tools for doing builds. It
@@ -110,8 +109,8 @@
are needed to build the coreboot toolchain. `gcc` and `gnat` have to be
of the same version.

-If you started with a different distribution that does not use apt, yum or
-pacman as its package manager, you might need to install other packages.
+If you started with a different distribution that does not use apt, yum or
+pacman as its package manager, you might need to install other packages.
Most likely they are named differently depending on your distribution.

### Step 2 summary - Download coreboot source tree
@@ -162,8 +161,8 @@
displayed the contents of the rom file.

### Step 7 summary - Install QEMU
-QEMU is a processor emulator which we can use to show the coreboot boot
-process in a virtualised environment.
+QEMU is a processor emulator which we can use to show the coreboot boot
+process in a virtualised environment.

### Step 8 summary - Run QEMU
Here's the command line broken down:
@@ -171,7 +170,7 @@
This starts the QEMU emulator with the i440FX host PCI bridge and PIIX3 PCI to
ISA bridge.
* `-bios build/coreboot.rom`
-Use the bios rom image that we just built. If this flag is left out, the
+Use the bios rom image that we just built. If this flag is left out, the
standard SeaBIOS image that comes with QEMU is used.
* `-serial stdio`
Send the serial output to the console. This allows you to view the coreboot

To view, visit change 38302. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2eb60f507bc67b3bbacaf62f958d069dc7fa0201
Gerrit-Change-Number: 38302
Gerrit-PatchSet: 1
Gerrit-Owner: Patrik Tesarik
Gerrit-MessageType: newchange