10 comments:
Please elaborate, what blob version you used for testing, and paste the newly added messages, and also measure and add timings.
Please also mention and elaborate on the newly addad blob `dram.elf`. How big is it? What does it do?
File src/soc/mediatek/mt8192/Makefile.inc:
I think, I’d be good to make that name configurable in Kconfig.
File src/soc/mediatek/mt8192/memory.c:
Patch Set #11, Line 75: static int dram_run_full_calibration(struct dramc_param *dparam)
Please measure the time of the blob execution (add CBMEM timestamps).
Patch Set #11, Line 83: return -1;
Please print an error message.
Patch Set #11, Line 86: return -2;
Please print an error message.
Patch Set #11, Line 135: printk(BIOS_ERR, "Failed to run fast calibration\n");
This with the new messages below is confusing. The return value should be printed.
Patch Set #11, Line 149: DRAM-K
What does DRAM-K stand for?
Patch Set #11, Line 149: Full Calibration
Starting full calilbration …
Patch Set #11, Line 153: printk(BIOS_INFO, "Full calibration passed\n");
It should be prefixed with some RAM related term or be more elaborate.
If the the different error codes are not considered (-1…-4), they shouldn’t be used.
To view, visit change 44570. To unsubscribe, or for help writing mail filters, visit settings.