Attention is currently required from: Arthur Heymans, Nico Huber.

View Change

1 comment:

• File src/northbridge/intel/gm45/northbridge.c:

  • Patch Set #3, Line 111:

    struct resource *upper_pci = find_resource(dev, IOINDEX_SUBTRACTIVE(2, 0));
    	if (upper_pci)
    		upper_pci->base = touud;
    
    	struct resource *lower_pci = find_resource(dev, IOINDEX_SUBTRACTIVE(1, 0));
    	if (lower_pci)
    		lower_pci->base = tolud;
    

    +1

    i'd also prefer to just report the correct resources.
    unrelated to this patch, but the IOINDEX_SUBTRACTIVE macros should probably also have the link argument dropped

To view, visit change 80465. To unsubscribe, or for help writing mail filters, visit settings.