Patch Set 1:
What does smell weird about that struct is that the 1 bit wide fields are signed integers while they should be unsigned integers

Generally one should avoid bit-fields when having to match with external spec. AFAIR it is not dictated in the standard that the first declared bit-field will consume LSB position. I was under impression that bit-fields would allocate minimum size of int but apparently, with packed attribute at least, only uint8_t is consumed here.

To view, visit change 41154. To unsubscribe, or for help writing mail filters, visit settings.