View Change
1 comment:
Commit Message:
Patch Set #3, Line 14: SMI handler
in SMI handlers it does not seem like a good idea to use a hardcoded value, but to use the one fetched from registers as it might be changed later on.
To view, visit change 37990. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6f6295c5eba9eb20e57ab56e7f965c8879e93d2
Gerrit-Change-Number: 37990
Gerrit-PatchSet: 3
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Jonathan Zhang <jonzhang@fb.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-CC: ron minnich <rminnich@gmail.com>
Gerrit-Comment-Date: Thu, 23 Jan 2020 18:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment