it should probably just be mapped 0:0x3f8, 1:0x2f8, 2:0x3e8, 3:0x2e8.

done

Thanks. What I'm mostly concerned about now is that this is mixed
with console options. UART_FOR_CONSOLE depends on CONSOLE_SERIAL.
So if anybody would want any Picasso UART with legacy interface they'd
be forced to enable serial console. That seems odd.

fixed

haven't tested the patch on hardware yet, but wanted to push it before the weekend

Patch set 4:Code-Review -1

View Change

To view, visit change 40322. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id08ff6428d4019303ebb6e44e13aba480cf1fde2
Gerrit-Change-Number: 40322
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 12 Sep 2020 00:00:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment