Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Caveh Jalali, Paul Menzel, Tim Wawrzynczak, Tim Van Patten, Eric Peers, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.

15 comments:

Commit Message:
- Patch Set #10, Line 7: common/acpi/dptc: Dynamic Thermal Table Switching Proposal
  Please make this a statement by adding a verb (in imperative mood) [1]. […]
  Done
- Patch Set #10, Line 9:
```
Thermal table switches to different modes to meet 6
user experience.
```
  Please use 72 characters per line. […]
  Done
Patchset:
- Patch Set #21:
  Hi all,
  Update new patch based on below fixed
  *Space before “==”
  *“Lid on” change to “Lid open”
  *Remove debug message
  *Combine STTB block
  *Update commit title and description
  And follow the suggestions, re-design the table switch method by
  adding PRTN in ec.asl when FEATURE_DYNAMIC_DPTC is configure
  (We can discuss if it should replace by TNCA)
  BR,
  Eric KY Cheng
File src/soc/amd/common/acpi/dptc.asl:
- Patch Set #10, Line 38: //Desktop + Lid on
  Please use C89 comment style (as above). (A space is missing after `//` too. […]
  Done
- Patch Set #10, Line 38: Lid on
  Does "Lid on" mean "lid open"?
  Done
- Patch Set #10, Line 39: STTB==0
  style: Add spaces around the `==`.
  Done
- Patch Set #10, Line 43: Printf ("EC : Desktop + Lid on")
  While these are fine for debug, we don't want/need to output these types of "Desktop + Lid on" state […]
  Done
- Patch Set #10, Line 44: //over 50
  After chatting with Raul, he pointed out that storing the previously applied table ID in a `Name`d o […]
  Done
- Patch Set #10, Line 45: 0x7B
  Ah, 50C is 122F, so maybe this is off by 1?
  Done
- Patch Set #10, Line 47: Printf ("EC : Table B")
  All of these "Table X" log statements should be moved into the `acpigen_write_alib_dptc_*` methods i […]
  Done
- Patch Set #10, Line 60:
```
        }

        If (\_SB.PCI0.LPCB.EC0.STTB==0)
        {
```
  Combine these blocks, so we don't need to read `STTB` multiple times.
  Done
- Patch Set #10, Line 83:
```
        }
        If (\_SB.PCI0.LPCB.EC0.STTB==1)
        {
```
  Make this an `Else`.
  Done
- Patch Set #10, Line 108: Printf ("EC: DPTC Call End(Should not show here)")
  This can be removed.
  Done
File src/soc/amd/common/acpi/dptc.asl:
- Patch Set #12, Line 44: TIN4
  These are all device specific values. […]
  Done
- Patch Set #12, Line 51: 0x76
  Please use decimal values instead of hex
  Done

To view, visit change 68471. To unsubscribe, or for help writing mail filters, visit settings.