Jacob Garber uploaded patch set #2 to this change.

View Change

sb/amd/{cimx,}/sb{700,800,900}: Prevent uninitialized reads

There are two hard things in computer science: cache invalidation,
naming things, and off-by-one errors. -- Anonymous

var_num records the number of initialized entries in the reg_var array.
However, this means the index of the last initialized element is one
less than the value of var_num, so we need to take that into account
when indexing into the array. This has already been fixed in several
other places (eg. sb/amd/pi/hudson/lpc.c), so let's also do so here.

Change-Id: Ibefabaca42866a3f2b22eff979c73badf86ac317
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: scan-build 8.0.0
---
M src/southbridge/amd/cimx/sb800/lpc.c
M src/southbridge/amd/cimx/sb900/lpc.c
M src/southbridge/amd/sb700/lpc.c
M src/southbridge/amd/sb800/lpc.c
4 files changed, 12 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/33790/2

To view, visit change 33790. To unsubscribe, or for help writing mail filters, visit settings.