Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72639 )
Change subject: ec/google/chromeec: clang-format ec_commands.h
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72639/comment/772c06ae_285a3a1a
PS1, Line 14: future updates don't get overwhelmed
: by inconsequential style changes
To solve the problem shouldn't we copy ec_commands.h from the EC repo instead? Otherwise future updates may still have the problem due to inconsistent clang-format configs in coreboot and EC repos.
TBH I think this file should be a direct copy from the EC repo with minimal modification (such as license). With this change people will have to run the clang-format tool every time they are updating ec_commands.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06
Gerrit-Change-Number: 72639
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 02:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment