Attention is currently required from: Kedar J. Karanje, Furquan Shaikh, vagdevi.p@intel.com, Tim Wawrzynczak, Subrata Banik, Vinay Kumar, Balaji Manigandan, Kane Chen, Patrick Rudolph, Baieswara Reddy Sagili.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56325 )
Change subject: soc/intel/alderlake: Configure the SKU specific parameters for VR domains
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/56325/comment/e3e3d060_06c831fe
PS9, Line 84: uint16_t mch_id = 0;
:
: if (!mch_id) {
: struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
: mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff;
: }
this is only used in the `else` case, could it go in that scope?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I434fd30b5bce3bfab5a5800a30317aaa04d9926a
Gerrit-Change-Number: 56325
Gerrit-PatchSet: 10
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: vagdevi.p@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: vagdevi.p@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Comment-Date: Mon, 02 Aug 2021 12:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment