Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.

View Change

1 comment:

• File src/device/device_util.c:

  • Patch Set #1, Line 255: dev

    I suppose the NULL-deref should not be a problem in the previous codes? Since it is blocked by the w […]

    The original code checked `dev` and `dev->upstream`:
    ```
    while (dev && dev->upstream && ...
    ```
    But then `dev` got overwritten:
    ```
            dev = dev->upstream->dev;
    ```
    and the new `dev` was dereferenced unchecked:
    ```
            if (dev->path...
    ```

    I don't know if it matters. A valid device tree should never have a NULL
    there. But the same applies to `dev->upstream` and we check it too. It
    was just inconsistent to check one but not the other.

To view, visit change 81957. To unsubscribe, or for help writing mail filters, visit settings.