Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35924 )
Change subject: Revert "soc/intel/cannonlake: Remove DMA support for PTT"
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35924/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35924/2//COMMIT_MSG@11
PS2, Line 11: Reason for revert: Breaks boot on Whiskey Lake-U System76 boards
The FSP version is the one from the current master branch of coreboot, Coffee Lake 7.0.64.40. […]
Thanks, Jeremy.
https://review.coreboot.org/c/coreboot/+/35924/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35924/3//COMMIT_MSG@20
PS3, Line 20: potentially
Not potentially. It is. These systems are using an ME with PTT enabled by way of FIT tool. Makes perfect sense with the whole story. Let's nuke potentially and explain this is expected given these systems' ME configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82f02c4a2b1cd2dbf95d4ca4a9edd314e78edd2
Gerrit-Change-Number: 35924
Gerrit-PatchSet: 3
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-Comment-Date: Thu, 10 Oct 2019 16:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Jeremy Soller
jeremy@system76.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment