Squashed changes into this one, updated copyrights, resolved gpio tables
9 comments:
Patch Set #3, Line 7: google/endeavour: add variant based on karma
Suggestion: Mention the baseboard and the new variant's name in the commit summary: […]
Done
File src/mainboard/google/fizz/variants/endeavour/gpio.c:
Patch Set #3, Line 22: gpio_table
Looks like this file is pretty much the same as `gpio.c` of the baseboard. […]
I was trying make it easier to review what changed from the baseboard but I should have just used another patchset. Squashed.
Patch Set #3, Line 237: early_gpio_table
Same question as above.
Done
Patch Set #3, Line 258: __weak
Why is this weak if it is being provided by the variant?
Done
Patch Set #3, Line 264: __weak
same here
Done
Patch Set #3, Line 271: cros_gpios
If baseboard is providing the same table as this, you probably don't need a separate table in the va […]
Done
File src/mainboard/google/fizz/variants/endeavour/include/variant/acpi/dptf.asl:
I found some more already in the tree. I'll push a change taking care of them.
Done
File src/mainboard/google/fizz/variants/endeavour/nhlt.c:
Patch Set #3, Line 20: __weak
This file as a whole also seems to come from the baseboard, rather than Karma.
Done
Patch Set #3, Line 29: __weak
same here.
Done
To view, visit change 36791. To unsubscribe, or for help writing mail filters, visit settings.