Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, EricR Lai.

Tim Wawrzynczak uploaded patch set #2 to this change.

View Change

mb/google/brya: Clear SLP_S0_GATE_L on ACPI sleep entry

On brya platforms, the SLP_S0_L signal is gated to the rest of the
platform by SLP_S0_GATE_L, which is under software control. Currently,
this GPIO is not touched on the S5 shutdown path, leading to the rest of
the platform observing the SLP_S0_L signal deassert far too late, and
thus the EC gets confused.

Currently, the EC power state machine observes the following
transitions during powerdown:
S0->S3->S5->G3->S3->S5->G3

With this patch:
S0->S3->S5->G3

BUG=b:186707518
TEST=observe power state transitions in EC console as described above

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I5500e701ac8731d141b51dc381609c80047dc1f8
---
M src/mainboard/google/brya/mainboard.asl
M src/mainboard/google/brya/wwan_power.asl
2 files changed, 18 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/58180/2

To view, visit change 58180. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5500e701ac8731d141b51dc381609c80047dc1f8
Gerrit-Change-Number: 58180
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-CC: Boris Mittelberg <bmbm@google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Attention: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset